Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make choco get its proxy settings also from environment Variables #605

Closed
c33s opened this issue Feb 2, 2016 · 5 comments
Closed

Make choco get its proxy settings also from environment Variables #605

c33s opened this issue Feb 2, 2016 · 5 comments

Comments

@c33s
Copy link

c33s commented Feb 2, 2016

as referenced in the issue #553 you linked the manual for proxy setup https://github.com/chocolatey/choco/wiki/Proxy-Settings-for-Chocolatey

it would be very good, for a automation tool, to get the proxy settings from the environmental variables:

HTTPS_PROXY=http://proxy.example.com:1080
HTTP_PROXY=http://proxy.example.com:1080
@ferventcoder
Copy link
Member

you mean use those if they are present?

@c33s
Copy link
Author

c33s commented Feb 2, 2016

yes, exactly

@majkinetor
Copy link

I second this. This is important for x-platform compatibility too. Linux folks would appreciate this.

Just as a reference, here is my Update-CLIProxy that creates those variables from explorer settings. I have it in my $PROFILE so linux tools (gem, bundler, pip etc.) work.

@ferventcoder ferventcoder modified the milestones: 0.9.10.x, 0.9.10.1, 0.9.10.2, 0.9.10.3 Jun 12, 2016
@ferventcoder ferventcoder modified the milestones: 0.9.10.3, 0.9.10.4, 0.9.10.5 Jun 22, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.1, 0.10.2 Sep 5, 2016
@ferventcoder ferventcoder removed this from the 0.10.1 milestone Sep 5, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.2, 0.10.3 Sep 20, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.3, 0.10.4 Oct 3, 2016
@abmoham
Copy link

abmoham commented Jan 24, 2017

I'd like to request that it also respect proxy bypass:

NO_PROXY=127.0.0.1,localhost,*.example.com

@ferventcoder
Copy link
Member

This will be implemented in 0.10.4

ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 27, 2017
If `http_proxy`/`https_proxy` are set in environment variables, use
those for Chocolatey automatically. If `no_proxy` is set, then use it
for the proxy bypass list.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 27, 2017
* stable:
  (chocolateyGH-1134) Show download progress for packages
  (chocolateyGH-1134) Specify Package Downloader
  (chocolateyGH-1165) fix - bypass on local set
  (chocolateyGH-605) Use Proxy From Environment Vars
  (chocolateyGH-1167) Remove quotes before Process call
  (chocolateyGH-1166) Fix: Multiple Licensed Sources
  (chocolateyGH-1165) Bypass Proxy on Local
  (chocolateyGH-1165) Config - Proxy Bypass List
  (chocolateyGH-262) Sources Explicitly Bypass Proxy
  (chocolateyGH-262) NuGet.Core - explicit source proxy ignore
ferventcoder added a commit that referenced this issue Mar 1, 2017
When proxy settings are determined from the environment, ensure they
are available for use with all areas of Chocolatey and not just the
PowerShell scripts.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Mar 1, 2017
* stable:
  (chocolateyGH-1111) Clean up messaging for licensed edition
  (chocolateyGH-262) Ensure explicit source proxy bypass
  (doc) update environment variables in readme
  (maint) update uninstall to core extension
  (chocolateyGH-262) source - proxy bypass logging
  (chocolateyGH-605) Ensure environment proxy settings available
  (maint) formatting
  (log) update checksum error message
  (maint) TabExpansion - new options for licensed
  (chocolateyGH-1173) Set proxy information at runtime
  (log) note when proxy settings became available
  (maint) add outputdirectory shorter option names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants