Package succeeds but software Install silently fails when Install-ChocolateyInstallPackage has the wrong arguments

[ferventcoder]

If a package tries to install something but doesn't pass the right arguments, do not silently state it is successful

https://gist.github.com/fredrikaverpil/b8b1ce5fd0bacca0a644#file-vcpython27_no_uninstall_possible-log-L84

[ferventcoder]

Found it, fileType is the switch. Since it is empty, it should fail.

choco/src/chocolatey.resources/helpers/functions/Install-ChocolateyInstallPackage.ps1

Lines 76 to 105 in 0426b74

	if ($fileType -like 'msi') {
	$msiArgs = "/i `"$file`""
	if ($overrideArguments) {
	$msiArgs = "$msiArgs $additionalInstallArgs";
	write-host "Overriding package arguments with `'$additionalInstallArgs`'";
	} else {
	$msiArgs = "$msiArgs $silentArgs $additionalInstallArgs";
	}
	Start-ChocolateyProcessAsAdmin "$msiArgs" 'msiexec' -validExitCodes $validExitCodes
	#Start-Process -FilePath msiexec -ArgumentList $msiArgs -Wait
	}
	if ($fileType -like 'exe') {
	if ($overrideArguments) {
	Start-ChocolateyProcessAsAdmin "$additionalInstallArgs" $file -validExitCodes $validExitCodes
	write-host "Overriding package arguments with `'$additionalInstallArgs`'";
	} else {
	Start-ChocolateyProcessAsAdmin "$silentArgs $additionalInstallArgs" $file -validExitCodes $validExitCodes
	}
	}
	if($fileType -like 'msu') {
	if ($overrideArguments) {
	$msuArgs = "$file $additionalInstallArgs"
	} else {
	$msuArgs = "$file $silentArgs $additionalInstallArgs"
	}
	Start-ChocolateyProcessAsAdmin "$msuArgs" 'wusa.exe' -validExitCodes $validExitCodes
	}