Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use package name/version from environment, not parameters #751

Closed
ferventcoder opened this issue May 27, 2016 · 0 comments
Closed

Use package name/version from environment, not parameters #751

ferventcoder opened this issue May 27, 2016 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug
Milestone
0.9.10

Comments

@ferventcoder
Copy link
Member

ferventcoder commented May 27, 2016 •
edited

There is a small issue that choco won't be able to force a package to re-download if it cannot find the files in the local cache. This is when the user passed parameter for package name does not match the actual package name. Use the environment variable instead when setting up paths so that the location is deterministic.
@ferventcoder ferventcoder added this to the 0.9.10 milestone May 27, 2016
@ferventcoder ferventcoder self-assigned this May 27, 2016
ferventcoder added a commit that referenced this issue May 28, 2016
@ferventcoder
(GH-751) Use package name/version from env vars
3959882 
Previously, there was a small issue that choco would not be able to
force a package to re-download if it could not find the files in the
local cache. This is due to using the user passed parameter for package
name instead of the actual package name where the code is looking for
the package. This is bad because it depends on the user to pass the
correct parameter and that may not be the case.

Instead of trusting input, make the pathing deterministic by using the
environment variables that choco set up for those values instead.
ferventcoder added a commit that referenced this issue May 28, 2016
@ferventcoder
Merge branch 'stable'
fc27200 
* stable:
  (doc) update CHANGELOG/nuspec
  (GH-753) Get-WebFileName Matches on Invalid Chars
  (doc) update CHANGELOG/nuspec
  (GH-356) Resolve sources by name
  (GH-732) Request/Response Timeout configurable
  (maint) formatting
  (GH-751) Use package name/version from env vars
  (GH-752) Combine Push timeout and execution timeout
  (GH-622) Remove NuGet temp folders
  (GH-622) Allow silent retries
  (GH-584) License loading occurs in DLL
  (GH-584) update licensing docs
  (doc) update CHANGELOG/nuspec
  (GH-733) Don't pass some args to dependencies
  (doc) update CHANGELOG/nuspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
2 participants
@ferventcoder @gep13