Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure log file path exists for arguments #758

Closed
ferventcoder opened this issue May 31, 2016 · 1 comment
Closed

Ensure log file path exists for arguments #758

ferventcoder opened this issue May 31, 2016 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Improvement
Milestone
0.9.10.2

Comments

@ferventcoder
Copy link
Member

ferventcoder commented May 31, 2016 •
edited

Lots of error opening log file for paths that should exist but may not for whatever reason. When a log file is passed, ensure that the path exists.

MSIEXEC dies immediately on log file folder issues and it really should not.
@ferventcoder ferventcoder added this to the 0.9.10 milestone May 31, 2016
@ferventcoder ferventcoder self-assigned this May 31, 2016
@ferventcoder ferventcoder modified the milestones: 0.9.10.1, 0.9.10 Jun 1, 2016
@ferventcoder ferventcoder modified the milestones: 0.9.10.1, 0.9.10.2, 0.9.10.3 Jun 17, 2016
@ferventcoder
Copy link
Member Author

Related to #813

ferventcoder added a commit that referenced this issue Jun 19, 2016
@ferventcoder
(GH-758) Ensure log path exists
1e18060 
Ensure the log directory exists by attempting to create it,
failing silently if not able to create the directory.
Windows Installer in particular will fail when the log directory
doesn't already exist.
ferventcoder added a commit that referenced this issue Jun 19, 2016
@ferventcoder
Merge branch 'stable'
fc1c895 
* stable:
  (version) 0.9.10.2
  (doc) update CHANGELOG/nuspec
  (GH-758) Ensure log path exists
  (GH-813) Fix double chocolatey logging folder
  (GH-813) Shorten Template default log path
  (doc) update default options help messages
  (maint) Don't log creation of folder
  (maint) formatting / add message consistency
  (GH-814) Ensure any version of choco
  (GH-811) Skip resource / licensed assemblies
  (version) 0.9.10.1
  (doc) update CHANGELOG/nuspec
  (GH-810) Install of choco sets exit code
  (GH-812) Upgrade 7zip to 16.02 to address CVEs
  (doc) Note functions Calling Set-PowerShellExitCode
  (GH-810) Fix - Cannot bind parameter exitCode
@ferventcoder ferventcoder changed the title Ensure log file path exists - and fix the log file arguments if necessary Ensure log file path exists Jun 19, 2016
@ferventcoder ferventcoder changed the title Ensure log file path exists Ensure log file path exists for arguments Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.9.10.2
Development

No branches or pull requests
2 participants
@ferventcoder @gep13