Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress of download does not clear the whole output line #875

Closed
batzen opened this issue Jul 26, 2016 · 2 comments
Closed

Progress of download does not clear the whole output line #875

batzen opened this issue Jul 26, 2016 · 2 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Up For Grabs
Milestone
0.10.0

Comments

@batzen
Copy link

batzen commented Jul 26, 2016

What You Are Seeing?

Progress of download does not clear the whole output line. This results in artifacts being displayed if the reported progress gets shorter. This happens, for example, when download progress switches from formatted MB to formatted GB.

What is Expected?

Progress being displayed without artifacts.

How Did You Get This To Happen? (Steps to Reproduce)

Upgrading or installing a package which downloads files larger or equal to 1 GB.

Output Log

Log won't help much here. Attaching screenshot instead.
The last part " 4)" in the screenshot is the artifact i am talking about.
screenshot 5
On 100% this changes to "Progress: 100% - Saving 6.77 GB of 6.81 GB (7272877423/7309161064) )" where the artifact is just " )".
@ferventcoder ferventcoder added this to the 0.9.10.4 milestone Jul 26, 2016
@ferventcoder ferventcoder self-assigned this Jul 26, 2016
@ferventcoder
Copy link
Member

ferventcoder commented Jul 26, 2016 •
edited

Related to #872

@bill-long bill-long mentioned this issue Aug 3, 2016
Closed
ferventcoder pushed a commit that referenced this issue Aug 3, 2016
@ferventcoder
(GH-875) Pad progress output line to console width
b7548cd 
Pad the progress output to ensure we cover the full width of the console,
leaving no artifacts behind.
ferventcoder added a commit that referenced this issue Aug 3, 2016
@ferventcoder
Merge branch 'pr873' into stable
00c7b88 
* pr873:
  (GH-875) Pad progress output line to console width
  (GH-872) Fix: Download progress never reaches completion
ferventcoder added a commit that referenced this issue Aug 3, 2016
@ferventcoder
Merge branch 'stable'
ada768a 
* stable:
  (GH-875) Pad progress output line to console width
  (GH-872) Fix: Download progress never reaches completion
@ferventcoder
Copy link
Member

Fixed in 0.9.10.4. Thanks @bill-long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Up For Grabs
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @batzen