Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use unparsed options as package names #983

Closed
ferventcoder opened this issue Sep 27, 2016 · 0 comments
Closed

Do not use unparsed options as package names #983

ferventcoder opened this issue Sep 27, 2016 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement
Milestone
0.10.2

Comments

@ferventcoder
Copy link
Member

When an option starts with - or --, that cannot be a package name. So do not add it to the list of package names.
@ferventcoder ferventcoder added this to the 0.10.2 milestone Sep 27, 2016
@ferventcoder ferventcoder self-assigned this Sep 27, 2016
@ferventcoder ferventcoder changed the title Do not take unparsed options as package names Do not use unparsed options as package names Sep 27, 2016
ferventcoder added a commit that referenced this issue Sep 30, 2016
@ferventcoder
(GH-983) Do not add unparsed options to package names
7ea5290 
When an unparsed option starts with `-` or `--`, that was not meant to
be a package name so do not add it to the list of packages to install.
A package also cannot start with a dash as its id so it is fine not to
add them to the list.
ferventcoder added a commit that referenced this issue Sep 30, 2016
@ferventcoder
Merge branch 'stable'
2c4dc5b 
* stable:
  (version) 0.10.2
  (doc) update CHANGELOG/nuspec
  (GH-992) allow uninstall scripts for side by side
  (GH-992) search for sidebyside install first
  (GH-992) Uninstall should always work with version
  (maint) RefreshEnv.cmd mentions cmd.exe
  (maint) fix message
  (spec) support no prompting
  (GH-986) Remove extra forward slashes in url
  (GH-573) Explain Failing Uninstall Options
  (GH-985) rollback automatically on user cancel
  (GH-984) Detect licensed options in FOSS
  (GH-983) Do not add unparsed options to package names
  (GH-982) Note AutoUninstaller in uninstall template
  (docs) clean up messaging for logo use policy
@ferventcoder ferventcoder mentioned this issue Dec 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.10.2
Development

No branches or pull requests
2 participants
@ferventcoder @gep13