(GH-1304) Wrapping HashTable calls inside parenthesis #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ferventcoder is there a problem with the appveyor build? |
Previously when running choco new the generated uninstall script would create a elseif statement which would output several warnings to the user if more than the expected registry keys was found. These warnings contains an incorrect use when calling properties on a hashtable and would instead output the full registry key and their subkeys instead of the number of keys found, and their display name. With this change the uninstall template will correctly generate the use of such properties and output the actual number of keys found and their display name. fixes #1304
|
Thanks! |
|
Rebased and merged into stable at 326a8ae. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when running choco new the generated uninstall script would
create a elseif statement which would output several warnings to the
user if more than the expected registry keys was found.
These warnings contains an incorrect use when calling properties
on a hashtable and would instead output the full registry key and their
subkeys instead of the number of keys found, and their display name.
With this change the uninstall template will correctly generate the
use of such properties and output the actual number of keys found
and their display name.
Closes #1304