(#886) Add tests for packages.config options #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbob
force-pushed
the
a886_packages_config
branch
from
3283981
to
2ea872a
Compare
corbob
changed the title
corbob
force-pushed
the
a886_packages_config
branch
2 times, most recently
from
5d48bc5
to
5b24c47
Compare
When using a packages.config file, output the evaluated package configuration to the debug stream so that it is available for troubleshooting (and our Pester tests). Also update the checksum type logic to store in the right property.
Add Pester tests to test the options passed via a packages.config file.
Update the packages.config to be easier to read in the Pester tests. Update the configurations to use specific strings instead of all of them being the same "string". This will allow us to identify that they are actually what they're supposed to be.
corbob
force-pushed
the
a886_packages_config
branch
from
9f320dc
to
9062644
Compare
|
@corbob thanks for noticing and fixing that bug that was added, as well as getting those E2E tests added 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Add tests for
packages.configoptions to ensure they're being set properly.This PR also adds debug logging so that Pester tests can see these options.
Motivation and Context
We added the ability to use these options, but didn't have tests to ensure they were working as intended. Case in point one of the Checksum Types was being set as the Checksum.
Testing
Change Types Made
Related Issue
Fixes #886
Change Checklist