(#886, 2693) Update packages.config install logging and add back resolve or load method for Assembly Resolution #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbob
force-pushed
the
packages-config-tests
branch
from
661f65b
to
ec8a17c
Compare
corbob
changed the title
corbob
force-pushed
the
packages-config-tests
branch
from
ec8a17c
to
0bae717
Compare
gep13
reviewed
Sep 29, 2022
AdmiringWorm
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
LGTM, but need to leave it up to @gep13 to decide whether we should mark the overload as obsolete or not (as already mentioned, I don't mind either way).
|
If everyone is happy, then I would say let's not add the |
gep13
force-pushed
the
packages-config-tests
branch
from
0bae717
to
3d005e6
Compare
Update the debug logging when a packages.config file is being used to output the start and end of the configuration on independent lines. This allows us to update the test to get these start and end points and not play guessing games with how long we think the output should be. Updating this test allows Chocolatey Licensed Extension to be included and the tests still pass.
Changing the interface or public methods are breaking changes which we need to wait with implementing before the next major release. As such, this commit adds back the old way of running the powershell host by adding an overload with the original contract for the interface that could possibly be used in other projects that makes use of the Chocolatey.Lib library.
gep13
force-pushed
the
packages-config-tests
branch
from
3d005e6
to
1758e5f
Compare
|
@corbob thanks for getting this fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Update the debugging output for the install from packages.config file to clearly delineate the start and end of the configuration output.
Add back the original definition of resolve_or_load_assembly to AssemblyResolution.
Motivation and Context
The output of the Configuration when Licensed Extension is installed is different from when just Open Source is in play. As such, the tests for the new functionality was failing. This updates the output to enable us to better test the command.
Chocolatey GUI fails to load with the update to
resolve_or_load_assembly, so added back the original definition.Testing
Change Types Made
Related Issue
Fixes #886
Fixes #2693
Change Checklist