Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed [A]ll - yes to all #2849

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Removed [A]ll - yes to all #2849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/chocolatey.tests/infrastructure/commandline/InteractivePromptSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ public class when_prompting_answer_with_dash_with_interactivePrompt : Interactiv
public override void Context()
{
base.Context();
choices.Add("all - yes to all");
choices.Add("all");
}

public override void Because()
Expand All @@ -683,17 +683,17 @@ public override void AfterObservations()
[Fact]
public void should_return_all_when_full_all_answer_is_given()
{
console.Setup(c => c.ReadLine()).Returns("all - yes to all");
console.Setup(c => c.ReadLine()).Returns("all");
var result = prompt();
result.ShouldEqual("all - yes to all");
result.ShouldEqual("all");
}

[Fact]
public void should_return_all_when_only_all_is_given()
{
console.Setup(c => c.ReadLine()).Returns("all");
var result = prompt();
result.ShouldEqual("all - yes to all");
result.ShouldEqual("all");
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/chocolatey/infrastructure.app/services/PowershellService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ public bool run_action(ChocolateyConfiguration configuration, PackageResult pack
this.Log().Info(ChocolateyLoggers.Important, () => @"choco feature enable -n allowGlobalConfirmation");

var selection = InteractivePrompt.prompt_for_confirmation(@"Do you want to run the script?",
new[] { "yes", "all - yes to all", "no", "print" },
new[] { "yes", "all", "no", "print" },
defaultChoice: null,
requireAnswer: true,
allowShortAnswer: true,
Expand Down