Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#508) Attempt to resolve relative paths for sources #2943

Merged
merged 4 commits into from
Jan 9, 2023
Merged

(#508) Attempt to resolve relative paths for sources #2943

merged 4 commits into from
Jan 9, 2023

Commits on Jan 6, 2023

  1. (chocolatey#508) Attempt to resolve relative paths for sources 

    When setting up NuGet sources, if NuGet is unable to parse the path,
this tries to resolve relative paths to absolute, and then retries
setting up the NuGet source. If the path is unable to be resolved, then
this ignores the error and lets NuGet handle the resulting invalid
source.

This path resolution requires the filesystem to be passed in. This
means that various method signatures change to allow access to the
filesystem.

When using NuGet.Core, then relative paths were able to be resolved.
But now with NuGet.Client, relative paths are resolved by clients,
not by libraries, which is why this change has to be made.
NuGet/NuGet.Client#3783
    @TheCakeIsNaOH
    TheCakeIsNaOH committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    69cc81f View commit details
    Browse the repository at this point in the history

  2. (chocolatey#508) Add unit tests for NuGet source parsing 

    This adds tests to ensure that NuGet is able to parse various types of NuGet
sources correctly. This includes http, https, and local paths, where local
paths include absolute, different types of relative paths, and UNC.
    @TheCakeIsNaOH
    TheCakeIsNaOH committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    0598097 View commit details
    Browse the repository at this point in the history

  3. (chocolatey#508) Tweak info/verbose list output 

    This makes the info output the same as it was when using NuGet.Core so
as to keep the info output the same as it is with v1.x
    @TheCakeIsNaOH
    TheCakeIsNaOH committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    dde3671 View commit details
    Browse the repository at this point in the history

  4. (chocolatey#508) Enable tests with relative path sources

    @TheCakeIsNaOH
    TheCakeIsNaOH committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    0e7b369 View commit details
    Browse the repository at this point in the history