Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#3446) (ENGTASKS-3631) Update GenerateDocs.ps1 #3447

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

st3phhays
Copy link
Member

Description Of Changes

The GenerateDocs.ps1 file has been modified to support the Astro framework that docs.chocolatey.org will be using.

  • Frontmatter keys are lowercase
  • import the Xref Component
  • Switch links to use the Xref Component
  • Ensure all code is within code blocks and not 4 spaces (.mdx does not recognize code blocks as 4 spaces)
  • Ensure NOTE and WARNINGS are formatted correctly
  • Update comments to use {/* stuff */} instead of <!-- stuff -->
  • Change file format to .mdx

Motivation and Context

The documentation site has been switched to the Astro framework, and the changes here allow it to build.

Testing

  1. Ran the GenerateDocs.ps1 file and copied the results into the docs repo.

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #3446

@st3phhays st3phhays self-assigned this May 20, 2024
@st3phhays st3phhays requested review from gep13 and vexx32 May 20, 2024 12:50
@st3phhays st3phhays marked this pull request as draft May 20, 2024 12:56
@st3phhays
Copy link
Member Author

This can be reviewed, but it may not be ready to merge until the Astro bits are ready to go into docs.

@st3phhays
Copy link
Member Author

This can not be released until after this PR has been merged: chocolatey/docs#993

The merging of this PR may require more changes to be made here, and changes to the files in the PR above might need to be fixed up to support Astro.

@st3phhays st3phhays changed the title (#3446) Update GenerateDocs.ps1 (#3446) Update GenerateDocs.ps1 (ENGTASKS-3631) Jun 4, 2024
@st3phhays st3phhays changed the title (#3446) Update GenerateDocs.ps1 (ENGTASKS-3631) (#3446) (ENGTASKS-3631) Update GenerateDocs.ps1 Jun 4, 2024
gep13
gep13 previously approved these changes Jun 11, 2024
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@st3phhays st3phhays marked this pull request as ready for review June 12, 2024 01:35
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

st3phhays and others added 3 commits June 12, 2024 05:49
The GenerateDocs.ps1 file has been modified to support the Astro
framework that docs.chocolatey.org will be using.

- Frontmatter keys are lowercase
- import the Xref Component
- Switch links to use the Xref Component
- Ensure all code is within code blocks and not 4 spaces
  (.mdx does not recognize code blocks as 4 spaces)
- Ensure NOTE and WARNINGS are formatted correctly
- Update comments to use `{/* stuff */}`  instead of `<!-- stuff -->`
- Change file format to `.mdx`
Strip out some things platyps falls over on, and add some things back
in after platyPS is done that we want/need the docs site to have.
Use xml to process xref nodes in the document.
@gep13
Copy link
Member

gep13 commented Jun 12, 2024

I am going to go ahead and merge this, since we don't need to wait on the CI builds passing.

@gep13 gep13 merged commit 8f23ca2 into chocolatey:develop Jun 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GenerateDocs.ps1 to support the Astro Framework
3 participants