(GH-346) Process with an id of is not running errors (posh v2 too) #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Howdy, would you mind reading through our contributing doc and fix up your commit message? See https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#prepare-commits in particular. :) |
The commit ea6f1ff tried to fix the following error: > Process with an id of XXX is not running It succeed for powershell v3, but not with v2. Using a .NET style start process it's compatible with powershell v2.
|
I hope this is better now, and fits your guidelines. According to the doc all specs must pass ... but I assume it's ok if the tests were failing before :) |
ferventcoder
changed the title
|
The CLA check didn't come up, can you please review and sign the CLA at https://www.clahub.com/agreements/chocolatey/choco? Thanks! |
|
And now it comes up. Nice. |
|
Thans @ferventcoder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This commit may have fixe the named error for powershell v3, but not for v2
Using a .NET style start process it's compatible with powershell v2.
Fix #346