Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only split after first colon when doing an override #1062

Merged
merged 1 commit into from Jun 28, 2022

Conversation

mikemhenry
Copy link
Contributor

Description

Allows users to specify an override like --override foo:bar:baz to be split into foo and bar:baz instead of foo bar baz which would break our parser. Common use case is to have a url as a key, ie some_path:http://s3.aws.com

Motivation and context

Resolves #1060

How has this been tested?

Tested locally.

Change log

Fixes bug where if a `:` was in a key, we could not override the arguement in our perses-cli. 

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1062 (045eeb3) into main (c4368a6) will decrease coverage by 1.78%.
The diff coverage is 100.00%.

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks. We might want tests for the CLI or the functions it uses to parse the arguments in the future, I'm thinking on extending the CLI to include the benchmarks so it might be not worth it now. LGTM!

@mikemhenry mikemhenry merged commit 99dab9d into main Jun 28, 2022
@mikemhenry mikemhenry deleted the fix/split_into_dict branch June 28, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override function in CLI does not accept colons :
2 participants