Adding constraints, fixing a couple tests. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, assuming that the constraints have been iterated to convergence, if there is a constraint, we will assume it is satisfied and set the corresponding logp to 0.0. |
pgrinaway
changed the title
Closed
|
Just waiting for the travis build. It's otherwise finished. |
|
Sweet!
|
|
I think the remaining failures are mine, so I'll merge this and fix. |
jchodera
added a commit
that referenced
this pull request
Feb 14, 2016
Adding constraints, fixing a couple tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a test API and added support for bond constraints. As noted in #50 , the only remaining issue is to determine the
constraint_tolerancefor the reverse logp.