Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] test new openmmtools version #1170

Closed
wants to merge 3 commits into from
Closed

Conversation

mikemhenry
Copy link
Contributor

Description

Motivation and context

Resolves #???

How has this been tested?

Change log


@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1170 (0cbb5d4) into main (f6787e8) will not change coverage.
The diff coverage is n/a.

@ijpulidos
Copy link
Contributor

This doesn't seem to be doing what we want it to do https://github.com/choderalab/perses/actions/runs/4434092394/jobs/7779743567?pr=1170#step:7:236 Maybe we need to remove the openmmtools entry from the test_env.yaml and only leave the pip option?

@mikemhenry
Copy link
Contributor Author

@mikemhenry
Copy link
Contributor Author

It looks okay, I can run the perses tests locally as well with the PR #1065 to double check

@mikemhenry
Copy link
Contributor Author

@ijpulidos you are correct, lets see if faf3e9c helps elucidate this

@mikemhenry mikemhenry closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants