Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to control the log level in the CLI #1198

Merged
merged 3 commits into from Jun 15, 2023
Merged

Document how to control the log level in the CLI #1198

merged 3 commits into from Jun 15, 2023

Conversation

mikemhenry
Copy link
Contributor

Description

Motivation and context

Resolves #1016

How has this been tested?

Change log

@mikemhenry mikemhenry requested a review from ijpulidos May 30, 2023 22:01
@mikemhenry
Copy link
Contributor Author

@ijpulidos ready for review! Could you double-check my spelling? Thanks! :)

@mikemhenry mikemhenry added this to the 0.10.2 Bugfix release milestone May 30, 2023
ijpulidos
ijpulidos approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Minor suggestion, not a blocker.

examples/new-cli/README.md Outdated Show resolved Hide resolved
@mikemhenry @ijpulidos
Update examples/new-cli/README.md
26046e7 
Co-authored-by: Iván Pulido <2949729+ijpulidos@users.noreply.github.com>
@mikemhenry mikemhenry enabled auto-merge (squash) May 31, 2023 16:47
auto-merge was automatically disabled June 15, 2023 22:09

Merge queue setting changed

@mikemhenry mikemhenry added this pull request to the merge queue Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #1198 (ce5cd00) into main (c99b682) will decrease coverage by 0.01%.
The diff coverage is n/a.

Merged via the queue into main with commit 9b20826 Jun 15, 2023
7 checks passed
@mikemhenry mikemhenry deleted the mikemhenry-patch-2 branch June 15, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijpulidos ijpulidos ijpulidos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.2 Bugfix release
Development

Successfully merging this pull request may close these issues.

Document how to set log level in new CLI
2 participants
@mikemhenry @ijpulidos