Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support openmm 7.6 #896

Merged
merged 4 commits into from Dec 6, 2021
Merged

Only support openmm 7.6 #896

merged 4 commits into from Dec 6, 2021

Conversation

mikemhenry
Copy link
Contributor

This adjusts our CI to only test 7.6 + nightly, sets the min version of openmm to 7.6 and removes and only env file.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #896 (69d94c8) into master (741dd72) will decrease coverage by 0.95%.
The diff coverage is n/a.

@mikemhenry
Copy link
Contributor Author

@ijpulidos I got some nan's in the python 3.9 tests so I will re-run, but assuming things pass this should be good for review and merge!

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I just think not pinning the openmm version should work better.

@@ -17,7 +17,7 @@ dependencies:
- numexpr
- autograd
- pymbar
- openmm=7.5.1
- openmm=7.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want to pin any specific openmm version. It should use the latest available and it would also not require manually changing it for future openmm releases. Isn't that the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is an issue with having to manually change as openmm releases come out since if a new version comes out that breaks things, then we would want to keep testing against the older version while we update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to other ideas! Also pinning the "oldest" version we support makes the logic of refining the env a bit easier in the CI, but we could probably refactor it so we don't need to do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin openmm >=7.6, not =!

@ijpulidos
Copy link
Contributor

Why is it trying to test OpenMM 7.5.1 in the checks?

@mikemhenry
Copy link
Contributor Author

Why is it trying to test OpenMM 7.5.1 in the checks?

In the settings for the repo, those checks are set to "required" so it expects them in the PR. Until we merge this one in, I didn't want to change the repo setting since that would affect other PRs.

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, for future releases of openmm. But a non-blocker.

.github/workflows/CI.yaml Outdated Show resolved Hide resolved
@mikemhenry mikemhenry enabled auto-merge (squash) December 6, 2021 21:45
@mikemhenry mikemhenry merged commit b5d65a6 into master Dec 6, 2021
@mikemhenry mikemhenry deleted the fix/pin_openmm_to_7.6 branch December 6, 2021 23:32
@mikemhenry mikemhenry mentioned this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants