-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sampler implementation in process #92
Conversation
I've temporarily ingested |
This is mostly done. Once some of the other issues I raised are cleaned up, I can finish the testing and we're off to the races with a very basic functional implementation. This currently only replicates the NCMC-geometry-NCMC scheme we have in |
Added tests for the whole sampler stack. Hopefully this will work once #103 is resolved! |
Did a bit more cleanup and documentation. Just waiting on @juliebehr's changes to finish. |
Also, the API for this shouldn't be considered final. I'm more than happy to change this however we want to make things easier. This is just a first stab at the whole stack. |
That's fine. I think the first stab is important because we want to get the paper out as well as get things started for collaborators. Taking a look now while the debugger takes its time... |
Probably easier to link to the whole new files: |
OK, I'm now stuck waiting on #93 too. |
What do you need from #93? I can just do that now and merge. Is there any reason we can't merge this first? |
See test failures for master. There were some thing being cleaned up in
|
Or maybe these are things I forgot to change after merging in changes from
master?
|
Looks like there are 3 failures in master:
|
Should we merge this then?
|
I think that would be best. |
Go for it then! Will have time to clean up anything I missed tonight.
|
Sampler implementation in process
Starting basic samplers implementation.
Very much in progress and untested. Just figuring out APIs right now.