Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples do not work with NumPy 1.24 #484

Open
mattwthompson opened this issue Dec 20, 2022 · 5 comments
Open

Examples do not work with NumPy 1.24 #484

mattwthompson opened this issue Dec 20, 2022 · 5 comments

Comments

@mattwthompson
Copy link
Contributor

Aliases for built-ins were deprecated in February 2021: https://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated

https://github.com/choderalab/pymbar/actions/runs/3736207271/jobs/6340264997
@mattwthompson
Copy link
Contributor Author

Fix in #485

@mattwthompson
Copy link
Contributor Author

This will also break in the future (~6-12 months):

  /home/runner/work/pymbar/pymbar/pymbar/mbar_solvers.py:763: DeprecationWarning: 'maxiter' has been deprecated in favor of 'maxfun' and will be removed in SciPy 1.11.0.

@mrshirts
Copy link
Collaborator

Any help from me needed on these, @mattwthompson ?

@mattwthompson
Copy link
Contributor Author

I don't think so, just a review & merge in the linked PR

@mattwthompson
Copy link
Contributor Author

For what it's worth, the package itself seems unimpacted by these changes, so no need to make a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrshirts @mattwthompson