Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemistry builds not compiling on dev #281

Closed
evaneschneider opened this issue Mar 31, 2023 · 3 comments
Closed

Chemistry builds not compiling on dev #281

evaneschneider opened this issue Mar 31, 2023 · 3 comments

Comments

@evaneschneider
Copy link
Collaborator

PR #277 added two utility function calls to chemistry_functions.cpp, but the headers aren't included, so chemistry builds do not compile. Adding the headers fixes the issue (but I haven't done it yet on dev, only on RT, which will not get merged in soon).

@bcaddy
Copy link
Collaborator

bcaddy commented Apr 3, 2023

I'll fix this. Should we add a chemistry build to our tests?

@evaneschneider
Copy link
Collaborator Author

Yeah, I think that's a good idea. We should probably spend a hack session looking at what code is / isn't covered in the current build matrix, and try to add whatever builds we need to get as much of the code covered as possible.

@bcaddy
Copy link
Collaborator

bcaddy commented Apr 4, 2023

Fixed in PR #283

@bcaddy bcaddy closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants