Enable clang-tidy checks #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaddy
changed the title
bcaddy
force-pushed
the
dev-hackday-2023-07-03
branch
4 times, most recently
from
a63d527
to
4698d26
Compare
bcaddy
force-pushed
the
dev-hackday-2023-07-03
branch
from
4698d26
to
51aba26
Compare
bcaddy
force-pushed
the
dev-hackday-2023-07-03
branch
from
51aba26
to
45ace1b
Compare
|
This should be ready to merge. I would like someone to take a look at the changes in commit 45ace1b since I changed the logic a bit. It should yield the same results, be clearer, and provide warning on a failure but I want a second set of eyes just in case. Pretty sure it's just the stuff in mpi_routines.cpp |
bcaddy
force-pushed
the
dev-hackday-2023-07-03
branch
6 times, most recently
from
626817b
to
9550e28
Compare
This check only failed in a few spots and it was with string literals operating with an unsigned int type so I set the IgnorePositiveIntegerLiterals option to true.
Enabled checks for - macro definitions - typdefs - aliases - enums
The ClassCase does cover structs so I removed the struct case line
While this would be a good check to have on it's just not feasible in GPU code.
bcaddy
force-pushed
the
dev-hackday-2023-07-03
branch
from
998a903
to
ef13273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hicpp-signed-bitwise
This check only failed in a few spots and it was with string literals operating with an unsigned int types so I set the
IgnorePositiveIntegerLiterals option to true.
misc-confusable-identifiers check
The only thing that triggered this was
a1andalin the Roe solver. It turns out the expression foralwas short and only used one place so I copied and pasted it there, eliminatingalentirely. I did the same forarto maintain symmetry.readability-identifier-naming
Fixed and enabled name case checking for:
cppcoreguidelines-pro-bounds-constant-array-index
Disabled. This would be good to have on but it's just not feasible in GPU code since it pretty much requires heavy use of the STL.