Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only minify CSS when watch: false. #442

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Only minify CSS when watch: false. #442

merged 1 commit into from
Mar 22, 2018

Conversation

goto-bus-stop
Copy link
Member

Previously, CSS was always minified, thrice:

With this patch, we only run clean-css directly once when using bankai build, and do not run it at all when using bankai watch. The one time in purify-css is still there until that PR is merged 🤷‍♀️

yoshuawuyts
yoshuawuyts approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neato

@goto-bus-stop goto-bus-stop merged commit 08a125e into master Mar 22, 2018
tornqvist pushed a commit to tornqvist/bankai that referenced this pull request Mar 22, 2018
@goto-bus-stop @tornqvist
Only minify CSS when watch: false. (choojs#442)
a705aa3
@goto-bus-stop goto-bus-stop deleted the less-minify branch March 30, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@goto-bus-stop @yoshuawuyts