-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emit('popState')... can't get it do anything #621
Comments
|
created a repro in https://github.com/yoshuawuyts/repro-choo-621, this behavior is confirmed. In our docs we're saying There's currently no event to navigate backwards (or forwards) through the browser's history. I agree we should probably have one. |
is this necessary when you can do |
We could mention |
@goto-bus-stop yeah, we probably should have such a method. Part of the event bus is to provide visibility as to which actions are being taken. Pretty great help for debugging haha. @heyitsmeuralex a PR to the docs mentioning this would be grand! |
makes sense! |
Resolves choojs#621
Note that this is still incorrectly documented on the website choojs/website#75 |
Expected behavior
Could be my misunderstanding or using the wrong pattern; seems like emit('popState') should call window.history.back()
Actual behavior
No observable behavior.
Steps to reproduce behavior
choo v.6.6.0
The text was updated successfully, but these errors were encountered: