Hash routing opt in #667
Hash routing opt in #667
Conversation
README.md
Outdated
| anchor links on the page is generally not recommended. | ||
| By default hashes are not taken into account when routing. Using hashes to | ||
| delimit routes (e.g. `/foo#bar`) is supported if the `hash` options set to | ||
| `true`. Regardles, when a hash is found we also check if there's an |
There was a problem hiding this comment.
missing the last s in regardless.
|
This is a great idea. It'll need to be a semver major right? |
|
Oops that dang close button is so close to the comment button :) |
|
I'm not clear why this would be a major change. In what case would it be breaking stuff? |
|
Since hash routing is enabled by default, changing it to be opt-in would break any app that currently relies on hashes being interpreted as part of the pathname. |
|
How about adding the hash option with default true in a minor release and switching to false in v7? |
|
A minor version defaulting to true would be a great way of getting this out there asap. I’m currently on vacation but can resolve the conflict and change the default in a day or two. |
tornqvist
force-pushed
the
hash-routing-opt-in
branch
from
c2dfa89
to
bea81e2
Compare
|
I switched it around to default hash routing to |
|
v6.13.0 🎉 |
* master: (71 commits) 6.13.3 Revert init order change Add browser tests (choojs#696) 6.13.2 Fix location missing on store init (choojs#695) Typo Fix in Readme (choojs#693) 6.13.1 Fix wrong this usage in nanohref integration (choojs#689) Some spelling & typo fixes in readme (choojs#688) Fix inspect script (choojs#654) Add v6 tests (choojs#674) Remove references to bel (choojs#678) 6.13.0 Add hash option (choojs#667) Add documentation on components (choojs#673) Update README.md (choojs#669) 6.12.1 6.12.0 typings: add app to app.use cb (choojs#665) update dependencies (choojs#663) ...
Resolves #666, resolves #440
Both newcomers as well as seasoned choo users keep stumbling over this and resolve to hackish workarounds or complex subclassing of choo.
Making hash routing opt-in, hash anchors will behave as expected as per browser defaults. By opting into hash routing hashes will be transformed to be a part of the pathname (this is the current default behavior).
Example with default new behavior: https://choo-hash-anchors.glitch.me
Example with hash routing enabled: https://choo-hash-anchors-enabled.glitch.me/my/app
I ended up factoring out nanolocation as the behavior had to be duplicated for location override.
This is most definitely a breaking change.