Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple properties support #16

Merged
2 commits merged into from
Feb 3, 2016

Conversation

JamesKyburz
Copy link
Collaborator

In react you can use the spread operator like so

<Element {...this.props} />

Unfortunately

hx`<Element ${...this.props} />`

isn't valid... However I propose

hx`<Element ${this.props} />`

As no key is given this can be handled in the parse which this pull request handles (hopefully in an ok way)

I have written two tests for this new functionality.

@ghost ghost merged commit 1a4a6ba into choojs:master Feb 3, 2016
@ghost
Copy link

ghost commented Feb 3, 2016

This looks great, thanks! I was thinking of implementing the same feature I just hadn't gotten around to it.

I've added you as a maintainer in the spirit of open open source.

@JamesKyburz
Copy link
Collaborator Author

:) Great thx!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant