Trailing newline whitespace should result in a space in text nodes (#142

) * failing test case for missing whitespace * trailing newline whitespace should result in a space
choojs · May 13, 2019 · 1b115a6 · 1b115a6
1 parent 5350635
commit 1b115a6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/append-child.js b/lib/append-child.js
@@ -99,7 +99,7 @@ module.exports = function appendChild (el, childs) {
           VERBATIM_TAGS.indexOf(nodeName) === -1) {
           value = lastChild.nodeValue
             .replace(leadingNewlineRegex, '')
-            .replace(trailingNewlineRegex, '')
+            .replace(trailingNewlineRegex, ' ')
             .replace(multiSpaceRegex, ' ')
 
           // Remove empty text nodes, append otherwise

diff --git a/tests/browser/elements.js b/tests/browser/elements.js
@@ -156,6 +156,18 @@ test('space between text and non-text nodes', function (t) {
   t.end()
 })
 
+test('space between text followed by non-text nodes', function (t) {
+  t.plan(1)
+  var result = html`
+    <p>
+      whitespace
+      <strong>is strong</strong>
+    </p>
+  `
+  t.equal(result.outerHTML, '<p>whitespace <strong>is strong</strong></p>', 'should have correct output')
+  t.end()
+})
+
 test('space between non-text nodes', function (t) {
   t.plan(1)
   var result = html`