strip empty text nodes #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
force-pushed
the
strip-empty-text-nodes
branch
from
19663e3
to
a04ff21
Compare
This was referenced May 2, 2017
Tests were acounting for random text nodes, this fixes the tests
20:51 <yoshuawuyts> toddself: \o/
20:56 <yoshuawuyts> toddself: think it's a patch release?
20:56 <yoshuawuyts> yeah right
21:03 <toddself> yeah |
|
|
|
This screws up my layouts for the same reason as stated in shama/yo-yoify#45 (comment)
|
goto-bus-stop
added a commit
to goto-bus-stop/shama-bel
that referenced
this pull request
May 13, 2017
This reverts commit 253d352.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strips empty text nodes, so the resulting DOM is a whole bunch cleaner. Thanks!