Add choria::group to manage groups
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
groups
branch
2 times, most recently
from
b2240b4
to
d5c8ecf
Compare
|
CI on Ruby 2.4 can probably be dropped (anything older than 2.7 is EOL and 2.7 reach EOL in 1 month). Puppet 6 ship with Ruby 2.5. Puppet 7 ship with Ruby 2.7. Puppet 8 will ship Ruby 3.2. Maybe we can just remove 2.4 for now, when Puppet 6 reach EOL (soon), we can remove 2.5 too. We can also add 3.1 / 3.2 anytime. But maybe this is for another PR? |
|
looks great, yeah feel free to do CI changes here, squash these commits to one then add one for the CI version changes etc. I havnt tested if all works on ruby 3 yet though myself |
ripienaar
requested changes
Feb 24, 2023
smortex
force-pushed
the
groups
branch
3 times, most recently
from
10780d2
to
2324376
Compare
|
I will review this one soon, been on a business trip! |
This defined type allow to conveniently manage groups of choria users.
Remove oldest version of Ruby (Puppet 6 is too modern for Ruby 2.4) and add recent versions. While here, switch from the legacy circleci ruby images to the new ones: https://circleci.com/developer/images/image/cimg/ruby
|
You can merge whenever you're ready @smortex |
|
Merged. I'll keep the branch around until I update our Puppet config to not track it at $WORK next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to a previous comment and recent discussion on slack. This PR add a Puppet defined type to help managing groups of users in choria policies.