Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect mcollective_facts_yaml_refresh cron to /dev/null #208

Closed
hanej opened this issue Nov 16, 2018 · 4 comments
Closed

Redirect mcollective_facts_yaml_refresh cron to /dev/null #208

hanej opened this issue Nov 16, 2018 · 4 comments
Labels
Projects

Comments

@hanej
Copy link
Contributor

hanej commented Nov 16, 2018

The mcollective_facts_yaml_refresh cron job is sending emails when the refresh_facts.rb job generates warnings on stderr. The 99% of the time the warnings are environment related and are intermittent so they can be safely ignored.

Pull request #207 opened for this.

@ripienaar ripienaar added the bug label Nov 16, 2018
@ripienaar ripienaar added this to BACKLOG in Work Board via automation Nov 16, 2018
@ripienaar ripienaar moved this from BACKLOG to NEXT in Work Board Nov 16, 2018
hanej added a commit to hanej/puppet-mcollective that referenced this issue Nov 16, 2018
ripienaar added a commit that referenced this issue Nov 16, 2018
(#208) Redirect cron output to /dev/null
@ripienaar
Copy link
Member

Thank you @hanej releases should come in the next week or two

Work Board automation moved this from NEXT to TEST Nov 16, 2018
@hanej
Copy link
Contributor Author

hanej commented Nov 17, 2018

I apologize @ripienaar, the commit I sent you doesn't property redirect stderr. It should either be &>/dev/null or >/dev/null 2>&1. The current commit is backwards. How would you like me to resolve?

@ripienaar
Copy link
Member

oh yeah I totally missed that doh

@ripienaar ripienaar reopened this Nov 17, 2018
Work Board automation moved this from TEST to BACKLOG Nov 17, 2018
@ripienaar
Copy link
Member

I reopened it - you can send another PR to fix it

hanej added a commit to hanej/puppet-mcollective that referenced this issue Nov 17, 2018
ripienaar added a commit that referenced this issue Nov 17, 2018
(#208) Properly redirect stderr and stdout
Work Board automation moved this from BACKLOG to TEST Nov 17, 2018
@ripienaar ripienaar moved this from TEST to Ready for Release in Work Board Nov 27, 2018
@ripienaar ripienaar moved this from Ready for Release to DONE in Work Board Nov 30, 2018
@ripienaar ripienaar moved this from DONE to Ready for Release in Work Board Nov 30, 2018
@ripienaar ripienaar moved this from Ready for Release to DONE in Work Board Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Work Board
  
DONE
Development

No branches or pull requests

2 participants