Facts script file mode flip-flop on Windows

[sigv]

File permissions changes on Windows for MCO directories were resolved with #217, however the refresh_facts.rb script file still experiences the same troublesome situation where in each Puppet run the mode gets changed, reporting all Windows systems as having been changed even though the actual underlying ACL on the system is unchanged.

Relevant resource: /manifests/facts.pp:17

Log:

> puppet agent -t
Info: Using configured environment 'development'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Info: Caching catalog for <redacted>
Info: Applying configuration version '2aa17cd1f912d346317c57587959ad56ad2a036a'
Notice: /Stage[main]/Mcollective::Facts/File[C:/ProgramData/PuppetLabs/mcollective/plugins/mcollective/refresh_facts.rb]
/mode: mode changed '0775' to '0755'
Notice: Applied catalog in 10.35 seconds

[ripienaar]

@sigv is this one a big pain for you? I could do a bug fix release should you be unable to carry a local path till next release

[sigv]

@ripienaar It is annoying to have Changed resources on our Puppetboard. I would believe this change to be beneficial to anyone running this on Windows as well, but at the same time, I would not say it is too critical that it can't wait until your usual monthly release cycle rolls around.

For now we are going to manually track the merge commit in our Puppetfile and will have to remember to bump it to the next release when it is pushed:

diff --git a/Puppetfile b/Puppetfile
index 011252c..d468a28 100644
--- a/Puppetfile
+++ b/Puppetfile
@@ -27 +27 @@ mod 'choria-choria', '0.13.0'
-mod 'choria-mcollective', '0.9.1'
+mod 'choria-mcollective', :git => 'https://github.com/choria-io/puppet-mcollective.git', :commit => '53481b8100481d3ad214c6ff379eba1fbde433d0'

[ripienaar]

Thanks @sigv I'll hold it over till my next cycle then unless something else comes up