This repository has been archived by the owner on Jan 4, 2021. It is now read-only.
(#523) handle MCollective::ClientTimeoutError #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
changed the title
The default behaviour of perpetually retrying connections is not suitable for clients, especially ones run as part of some automation as they might never exit This respects the connection_timeout configuration option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On clients the behaviour of never ending reconnects is a problem when
running some client in an automation since you might end up getting
stuck forever in a loop should the configuration be incorrect
This allows setting plugin.nats.max_reconnect_attempts to a integer
setting, it defaults to -1 as today