Skip to content
This repository has been archived by the owner on Apr 15, 2023. It is now read-only.

Switched to Moka based cache/lock layer and was able to implement Primary Keys! #30

Merged
merged 14 commits into from Oct 10, 2021

Conversation

chotchki
Copy link
Owner

Merging this back into trunk. Will evaluate mass amounts of tickets for closure.

Closes #29
Closes #27
Closes #25
Closes #24
Closes #2

@chotchki chotchki self-assigned this Oct 10, 2021
@github-actions
Copy link

Test Results

    1 files  ±0      9 suites  +8   0s ⏱️ ±0s
109 tests +9  109 ✔️ +12  0 💤 ±0  0  - 3 

Results for commit efa726e. ± Comparison against base commit 2837532.

This pull request removes 8 and adds 17 tests. Note that renamed tests count towards both.
engine::io::block_layer::file_manager::file_executor::tests ‑ test_rollover
engine::io::block_layer::file_manager::file_executor::tests ‑ test_simple_startup
engine::io::block_layer::file_manager::file_operations::tests ‑ test_make_sub_path
engine::io::block_layer::file_manager::resource_formatter::tests ‑ test_uuid_formating
engine::io::block_layer::file_manager::tests ‑ test_roundtrips
engine::io::block_layer::lock_cache_manager::tests ‑ test_nonzero
engine::io::block_layer::lock_cache_manager::tests ‑ test_repeated_read
engine::io::block_layer::lock_cache_manager::tests ‑ test_roundtrip
create_table_with_nullable
engine::io::block_layer::file_manager2::tests ‑ test_roundtrips
engine::io::block_layer::file_operations::tests ‑ test_make_sub_path
engine::io::block_layer::lock_manager::tests ‑ test_locking
engine::io::block_layer::resource_formatter::tests ‑ test_uuid_formating
engine::io::index_formats::btree_leaf::tests ‑ sizes_match
engine::io::page_formats::page_header::tests ‑ sizes_match
engine::io::row_formats::item_pointer::tests ‑ sizes_match
engine::io::row_formats::null_mask::tests ‑ sizes_match
engine::objects::sql_tuple::tests ‑ sizes_match
…

@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #30 (efa726e) into main (2837532) will increase coverage by 4.30%.
The diff coverage is 82.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   77.42%   81.73%   +4.30%     
==========================================
  Files          85       82       -3     
  Lines        6525     6619      +94     
==========================================
+ Hits         5052     5410     +358     
+ Misses       1473     1209     -264     
Impacted Files Coverage Δ
src/engine/io/block_layer/resource_formatter.rs 100.00% <ø> (ø)
src/engine/io/page_formats/page_id.rs 18.91% <0.00%> (-9.09%) ⬇️
src/engine/io/page_formats/page_offset.rs 81.53% <ø> (-18.47%) ⬇️
src/engine/io/index_manager.rs 45.33% <45.91%> (+12.60%) ⬆️
src/engine/io/constraint_manager.rs 58.65% <57.14%> (-9.04%) ⬇️
src/engine/io/index_formats/btree_node.rs 68.69% <66.66%> (-15.35%) ⬇️
src/engine/io/index_manager/find_leaf.rs 65.92% <71.18%> (-22.50%) ⬇️
src/engine/io/block_layer/free_space_manager.rs 69.65% <81.57%> (-25.50%) ⬇️
src/engine/io/row_manager.rs 70.50% <83.52%> (-11.57%) ⬇️
src/engine/io/visible_row_manager.rs 77.57% <83.87%> (+5.77%) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2837532...efa726e. Read the comment docs.

@chotchki chotchki merged commit 8bee760 into main Oct 10, 2021
@chotchki chotchki deleted the Moka branch October 10, 2021 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant