Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPLORER #195

Closed
qirieshkaclwn opened this issue Dec 22, 2023 · 30 comments
Closed

EXPLORER #195

qirieshkaclwn opened this issue Dec 22, 2023 · 30 comments

Comments

@qirieshkaclwn
Copy link

  • 原始消息: EXPLORER asf
  • Access: Owner
  • ASF 版本: last
  • 插件版本: last
    ==========================================
    {
    "EULA": true,
    "Statistic": true,
    "DevFeature": true
    }
    the plugin does not view the list, the function only worked on 1 account
@qirieshkaclwn
Copy link
Author

i am retard

@d1ret
Copy link

d1ret commented Dec 23, 2023

Ты пофиксил это?

Я так понял при юзании эксплорера у тебя тоже не забирает карты? Но при этом если зайти вручную на акк ,то карта даётся?

@reanoff
Copy link

reanoff commented Dec 23, 2023

It doesn't collect from me

@woctezuma
Copy link

It works fine for me on unlimited bot accounts.

Make sure the cards have not been automatically forwarded to your main account before you noticed.

@reanoff
Copy link

reanoff commented Dec 23, 2023

У меня это отлично работает с неограниченным количеством учетных записей ботов.

Убедитесь, что карты не были автоматически перенаправлены на ваш основной аккаунт до того, как вы заметили.

does not work

@reanoff
Copy link

reanoff commented Dec 23, 2023

Explore discovery queue task will start immediately
But the cards don't fall out

@reanoff
Copy link

reanoff commented Dec 23, 2023

When manually, the card will drop out
image

@d1ret
Copy link

d1ret commented Dec 23, 2023

same

@chr233
Copy link
Owner

chr233 commented Dec 23, 2023

see ASF's manual https://github.com/JustArchiNET/ArchiSteamFarm/wiki/Configuration#autosteamsaleevent

what this command actually do is reset the ASF's timer.

@CrazyGhostRider
Copy link

Yes. Does not work.

@Unriot
Copy link

Unriot commented Dec 23, 2023

same, whats gonna be wrong?

@woctezuma
Copy link

Do you guys use the latest version of ASF?

@Unriot
Copy link

Unriot commented Dec 23, 2023

Do you guys use the latest version of ASF?

yeah sure:

ASFEnhance 2.0.6.0
MobileAuthenticatorPlugin 5.5.0.11
ASF Achievemenevement Manager Ex 1.0.2.0
ItemsMatcherPlugin 5.5.0.11
SteamTokenDumperPlugin 5.5.0.11

image

but still no card

@chr233
Copy link
Owner

chr233 commented Dec 24, 2023

This bug has a low priority, and I have to do more important work, it will be slow to fix it.

@qirieshkaclwn
Copy link
Author

у меня была проблема в другом и я её пофиксил но сейчас у меня
image

@qirieshkaclwn
Copy link
Author

qirieshkaclwn commented Dec 24, 2023

пишет что 0 но если собрать вручную то пишет -1 в стим
Come back tomorrow to earn another card by browsing your Discovery Queue!
на всех аккаунтах

@qirieshkaclwn
Copy link
Author

qirieshkaclwn commented Dec 24, 2023

@chr233 can you make a version of the plugin without checking if the card is available?

@chr233
Copy link
Owner

chr233 commented Dec 24, 2023

@chr233 can you make a version of the plugin without checking if the card is available?

not understand what u want, can u explain more?

@d1ret
Copy link

d1ret commented Dec 24, 2023

@chr233 can you make a version of the plugin without checking if the card is available?

Как отметил chr23 - команда всего лишь сбрасывает таймер, на который ориентируется ASF.
А значит, это проверку нужно убирать в самом ASF

@chr233
Copy link
Owner

chr233 commented Dec 24, 2023

what asfenhance do is reset the ASF's timer, the core logic is in the ASF, I cant do that

@qirieshkaclwn
Copy link
Author

steam says "Today you can get 0 more cards if you continue to view the list of recommendations."
if I register EXPLORER ASF
I'll see it in the console
"Come back tomorrow to earn another card by browsing your Discovery Queue!"
but if you collect it manually, steam will write "Today you can get -1 more cards if you continue to view the list of recommendations." and will issue a card

@qirieshkaclwn
Copy link
Author

can you remove the check that leads us to "Come back tomorrow and get another card by looking at your discovery queue!"

@woctezuma
Copy link

woctezuma commented Dec 24, 2023

Today you can get -1 more cards

The -1 is a bit weird, no? Maybe it is part of the issue?

cf. #195 (comment)

Picture

cf. #195 (comment)

Picture

@darkdroider
Copy link

Same error here.

@d1ret
Copy link

d1ret commented Dec 28, 2023

I fixed it in ASF SteamSaleEvent.cs code :)

Is this happening because ASF first checks if the sale card is available?

If so, a new recommendation list is generated.

To fix this, I cut out the code to make ASF send a request to generate a new recommendation list.

@woctezuma
Copy link

Is this happening because ASF first checks if the sale card is available?

I see. So the issue stems from the negative number of cards available returned by Steam.

@Igorelysss
Copy link

This line checks whether the discovery queue is available?
private async Task<bool?> IsDiscoveryQueueAvailable()

@d1ret
Copy link

d1ret commented Dec 28, 2023

This line checks whether the discovery queue is available? private async Task<bool?> IsDiscoveryQueueAvailable()

Yes.
But I just cut the function call out of "for"

Was:

for (byte i = 0; (i < MaxSingleQueuesDaily) && Bot.IsConnectedAndLoggedOn && (await IsDiscoveryQueueAvailable().ConfigureAwait(false)).GetValueOrDefault(); i++)

became:

for (byte i = 0; (i < MaxSingleQueuesDaily) && Bot.IsConnectedAndLoggedOn; i++)

@Igorelysss
Copy link

Thanks

@chr233
Copy link
Owner

chr233 commented Jan 4, 2024

honestly, this works fine in my environment

@chr233 chr233 closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants