Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Bad search text legibility with a light primary color #43

Closed
davquar opened this issue Oct 25, 2022 · 5 comments
Closed

[Bug]: Bad search text legibility with a light primary color #43

davquar opened this issue Oct 25, 2022 · 5 comments
Labels
Bug Bugs. Crashes or something isn't working

Comments

@davquar
Copy link

davquar commented Oct 25, 2022

Bug Summary

The foreground color of the search bar is white, hence If the user has a light primary color, the legibility is low.

Version

0.4.0

Steps to reproduce the bug

No response

Screenshots or Screen recordings

SmartSelect_20221025-081849_Phonograph Plus

Environment

No response

Other helpful information

No response
@davquar davquar added the Bug Bugs. Crashes or something isn't working label Oct 25, 2022
@chr56
Copy link
Owner

chr56 commented Oct 25, 2022

Confirmed, kind of busy these days, it would be fixed soon (make text contrastes to primary color).

@chr56
Copy link
Owner

chr56 commented Oct 25, 2022 •
edited

Screenshot_20221026-004740

Since a9d5668,
work for text is done, the works for icons are left to be done.

@chr56
Copy link
Owner

chr56 commented Oct 28, 2022

photo_2022-10-28_22-26-24

Currently, except 'back' icon and placeholder hint text, the contrast problem was "partially" fixed. -> v0.4.1

Because I am planning to make a brand new Search Page, I have no motive (and no energy) to fix it completely and work on codes that would be removed eventually.

@chr56 chr56 added Postponed just put it aside for a while (?) and removed Postponed just put it aside for a while (?) labels Oct 28, 2022
@chr56
Copy link
Owner

chr56 commented Oct 29, 2022 •
edited

By accident, I found where the problem is (the tint-color library "blocks" my manual way to override colors).

And it finally is fixed since 69e4865 (it should be in next version).

PS: the overflow menu icon ("the three dots" icon) color (which is always white before this version) is fixed as well.

Screenshot_20221029-211649

Screenshot_20221029-211639

@chr56 chr56 added the Closing The issue was done and would be closed soon label Oct 29, 2022
@chr56
Copy link
Owner

chr56 commented Nov 27, 2022

Closed, due to release of v0.5.0

@chr56 chr56 closed this as completed Nov 27, 2022
@chr56 chr56 removed the Closing The issue was done and would be closed soon label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bugs. Crashes or something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davquar @chr56