CMap: Source property fix and remove branching #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for ColorMap, the source property did not set ._source, which caused the getter of ColorMap.source to always return None; this commit sets ._source in the setter - in ColorMap._parse, the value was computed conditionioned with if ... elifon the token type, which could either bei shortcolor or longcolor, but implied the possibility that neither could be true; this commit removes the branching and introduces value_it, which is either token.value itself or an iterator, such that the value assignment is independent of the color length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the getter of ColorMap.source to always return None; this commit sets
._source in the setter
elifon the token type, which could either bei shortcolor or longcolor,
but implied the possibility that neither could be true; this commit
removes the branching and introduces value_it, which is either
token.value itself or an iterator, such that the value assignment is
independent of the color length