Pass parameter names to param_mod to fix ZPlus and AlphaBeta negative params #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `mod_params` will now pass the parameter name as the second positional argument to `param_mod` - this makes parameters distinguishable, such that they can be modified differently - rules implemented using BasicHook were adapted: the param_mod functions now need a second positional argument - custom rules must be updated in the same way - this update fixes in the rules ZPlus and AlphaBeta, which were incorrect when there were negative biases, as having negative biases can in any case cause negative outputs - the rules' param_mod functions specifically handle parameters named 'bias' differently
chr5tphr
force-pushed
the
named_param_mod
branch
from
ef7a599
to
dce0aee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod_paramswill now pass the parameter name as the second positionalargument to
param_modthis makes parameters distinguishable, such that they can be modified
differently
rules implemented using BasicHook were adapted: the param_mod
functions now need a second positional argument
custom rules must be updated in the same way
this update fixes in the rules ZPlus and AlphaBeta, which were incorrect
when there were negative biases, as having negative biases can in any
case cause negative outputs
the rules' param_mod functions specifically handle parameters named
'bias' differently