New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getauthorshortid() breaks if error found #2

Open

chrMongeau opened this issue Jul 20, 2020 · 0 comments

Owner

chrMongeau commented Jul 20, 2020

If the API call returns an error, the following breaks ungraciously:

repec/R/getauthorshortid.R

Lines 37 to 42 in 1365d50

    
           res <- jsonlite::fromJSON(f) 
        
           cols_ord <- c('shortid', 'name', 'last', 'first', 
        
                         'middle', 'suffix', 'repecurl') 
        
           return(res[cols_ord])

Should add error checking as in:

repec/R/repec_api_with_id.R

Lines 44 to 46 in 1365d50

    
           if ('error' %in% names(res)) { 
        
             stop('RePEc API returned an error. Are you using a valid `code`?') 
        
           }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment