Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental warp support #17

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Jan 9, 2020

warp 0.2 makes some changes in how it handles custom rejections. To allow an error to be used as a custom rejection, it needs to implement warp::reject::Reject.

This patch implements this trait on that type.

@chridou
Copy link
Owner

chridou commented Jan 9, 2020

Warp support should be in this lib.

I also had a look into warp and found out that it uses hyper::Body. Maybe we can also add an implementation for this which would then add capabilities for all web frameworks based on hyper.

Edit: All frameworks that use the Response<T> from the http crate with hyper::Body as the payload.

@thomaseizinger
Copy link
Contributor Author

I also had a look into warp and found out that it uses hyper::Body. Maybe we can also add an implementation for this which would then add capabilities for all web frameworks based on hyper.

Totally agree, I'd expect this to be a separate feature-flag (with_hyper if we follow the current convention) though, no?

@thomaseizinger
Copy link
Contributor Author

warp 0.2 got released!

I've updated the PR to use the version from crates.io!

@chridou chridou merged commit 7f565b7 into chridou:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants