Fix memory overwriting issue caused by buffer rework #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2014 01:29
The HDS module uses “memoryview” objects, which are not “bytearray” objects, but still need copying. Simplify by always calling bytes() without checking the type of object. With a “bytes” object input the time taken is still independant of the size of the buffer: Direct bytes() call: 1.8 µs (Python 3.3) or 0.40 µs (Python 2.7) Instance check: 0.7 µs (Python 3.3) or 0.6 µs (Python 2.7)
chrippa
added a commit
that referenced
this pull request
Feb 14, 2014
Fix memory overwriting issue caused by buffer rework
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue caused by commit fe46a8e “Refactor the basic buffer” in 1.7.3, and seen when streaming HDS to a player. I also added a test case :)