Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVCatchup.com Plugin #775

Merged
merged 5 commits into from Mar 7, 2015
Merged

TVCatchup.com Plugin #775

merged 5 commits into from Mar 7, 2015

Conversation

blxd
Copy link
Contributor

@blxd blxd commented Mar 4, 2015

A new plugin to support www.tvcatchup.com streams - might be geo-restricted to the UK.


@classmethod
def can_handle_url(self, url):
print "hi!", url
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be here? It’s not Python 3 syntax anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not meant to be there at all... My bad, was testing it before - crappy debug method.

@@ -66,6 +66,7 @@ tga - star.plu.cn Yes No
- star.tga.plu.cn
tv4play - tv4play.se Yes Yes Streams may be geo-restricted to Sweden.
Only non-premium streams currently supported.
tvcatchup - tvcatchup.com Yes No Streams may be geo-restricted to Great Britain.
- fotbollskanalen.se
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are breaking up the tv4play entry here, the fotbollskanalen.se line should be directly under the tv4play lines.

@blxd
Copy link
Contributor Author

blxd commented Mar 5, 2015

Cool, I will correct these on this branch and on the other pull request.
Good to see a response from you too, I plan to submit a couple of other plugins - mainly for live TV, so it's good to have some feedback. It took a bit of poking around to see how the plugins are written, but it is fairly straightforward.

chrippa added a commit that referenced this pull request Mar 7, 2015
@chrippa chrippa merged commit cb0f103 into chrippa:develop Mar 7, 2015
@chrippa
Copy link
Owner

chrippa commented Mar 7, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants