Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin Core v23.0 compatibilty updates #273

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Bitcoin Core v23.0 compatibilty updates #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
008d9ac
Use fees.base instead of fee for mempoolentry in histogram
andrewtoth Jun 8, 2022
9874f58
Update README for manually creating Bitcoin Core wallet
andrewtoth Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,10 @@ which bitcoin addresses they are interested in.
[verify the digital signatures](https://bitcoin.stackexchange.com/questions/50185/how-to-verify-bitcoin-core-release-signing-keys)
of any binaries before running them, or compile from source. The Bitcoin node
must have wallet functionality enabled, and must have the RPC server switched on (`server=1`
in bitcoin.conf). Create a wallet dedicated to Electrum Personal Server by adding
`wallet=electrumpersonalserver` to the bitcoin.conf file.
in bitcoin.conf). Create a wallet dedicated to Electrum Personal Server by running
`bitcoin-cli createwallet electrumpersonalserver true true "" false false true`
for Bitcoin Core v23.0 and up, or
`wallet=electrumpersonalserver` to the bitcoin.conf file for previous versions.

- If you dont already have it, download and install
[Electrum bitcoin wallet](https://electrum.org/), and set up your Electrum
Expand Down
2 changes: 1 addition & 1 deletion electrumpersonalserver/server/mempoolhistogram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def poll_update(self, timeout):
mempool_tx = self.rpc.call("getmempoolentry", [txid])
except JsonRpcError:
continue
fee_rate = 1e8*mempool_tx["fee"] // mempool_tx["vsize"]
fee_rate = 1e8*mempool_tx["fees"]["base"] // mempool_tx["vsize"]
self.mempool[txid] = (fee_rate, mempool_tx["vsize"])

return poll_interval_change