Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Commit

Permalink
set default donation amount in tumbler to zero
Browse files Browse the repository at this point in the history
  • Loading branch information
@chris-belcher
chris-belcher committed Oct 29, 2015
1 parent 6712269 commit 0243b70
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tumbler.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,8 @@ def main():
'This option controls the parameters of the normal distribution curve. (mean, standard deviation). default=(4, 1)')
parser.add_option('--mintxcount', type='int', dest='mintxcount', default=1,
help='The minimum transaction count per mixing level, default=1')
parser.add_option('--donateamount', type='float', dest='donateamount', default=1.5,
help='percent of funds to donate to joinmarket development, or zero to opt out')
parser.add_option('--donateamount', type='float', dest='donateamount', default=0,
help='percent of funds to donate to joinmarket development, or zero to opt out (default=0%)')
parser.add_option('--amountpower', type='float', dest='amountpower', default=100.0,
help='The output amounts follow a power law distribution, this is the power, default=100.0')
parser.add_option('-l', '--timelambda', type='float', dest='timelambda', default=30,
Expand Down

4 comments on commit 0243b70

@dooglus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "--donateamount=0%" work? If not it would be clearer if you left the '%' out:
(default=0)

@AdamISZ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dooglus Yeah, I guess so, or maybe handle either format on input.
@chris-belcher Thanks for the change, I still think it would be good to put a prompt in on start up, so that people at least give donation a thought. But I don't think it's a dealbreaker either way.

@BitPopCoin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be 1% but confirm with a prompt and let it be changed every time. You went from 1.5 to 0...

@adlai
Copy link
Contributor

@adlai adlai commented on 0243b70 Nov 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BitPopCoin you're a bit late to the shitfest.

Please sign in to comment.