Skip to content

Commit

Permalink
riemann-health service: add procps to path (NixOS#19237)
Browse files Browse the repository at this point in the history
  • Loading branch information
@chris-martin
chris-martin committed Oct 5, 2016
1 parent 78b5ce3 commit 57023ab
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions nixos/modules/services/monitoring/riemann-tools.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ in {

systemd.services.riemann-health = {
wantedBy = [ "multi-user.target" ];
path = [ procps ];
serviceConfig = {
User = "riemanntools";
ExecStart = "${healthLauncher}/bin/riemann-health";
Expand Down

2 comments on commit 57023ab

@groxxda
Copy link

@groxxda groxxda commented on 57023ab Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change but it may be cleaner to fix the path in riemann-tools build or make the package propagate procps dependency

@chris-martin
Copy link
Owner Author

@chris-martin chris-martin commented on 57023ab Oct 5, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the example of 6e7d708, but I agree it's nice to have working executables that you can use without the service.

I think the ideal solution might be a wrapper as a new package that depends on riemann-tools, because riemann-tools has a lot of other programs bundled in it that probably don't have this dependency.

I'm hoping to just get an expedient fix into production though. Also I'm going to want to pull the fix into 16.09, so I figure we ought to keep it minimal.

Please sign in to comment.