Add support for . in project paths
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit tests were created to vet the regex updates as they can be very fiddly. Fixed issue with getting 404 when using any GitlabCli commands that interrogate the current folder for git information. Projects can have a `.` in their path and this wasn't accomodated for in the current regex Got mired in not capturing `.git` when it's there. There are two formats for git repo urls that aren't http based. These can have either .git or not on the end when running `git config --get remote.origin.url` For some reason I wasn't able to figure that part out. Ended up with a best effort just removing .git from the end. To invoke the tests run `Invoke-Pester` in the root of the repo, it should find them automatically.
|
Awesome -- I'd been looking into Pester, but never had the chance to contextualize it This will be a handy tool moving forward -- thanks for the heavy lifting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
The unit tests were created to vet the regex updates as they can be very fiddly.
Fixed issue with getting 404 when using any GitlabCli commands that interrogate the current folder for git information. Projects can have a
.in their path and this wasn't accomodated for in the current regex Got mired in not capturing.gitwhen it's there. There are two formats for git repo urls that aren't http based. These can have either .git or not on the end when runninggit config --get remote.origin.urlFor some reason I wasn't able to figure that part out. Ended up with a best effort just removing .git from the end.
To invoke the tests run
Invoke-Pester -Output Detailedin the root of the repo, it should find them automatically.