-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: detach/destroy or getUserMedia stream.end() ability #13
Comments
The recorder object is intended to be reused and thus holds onto the stream On 4 May 2015 at 16:09, Kequc notifications@github.com wrote:
|
Forgot to say thanks for your comment, and I will consider adding a destroy() method if It could be implemented nicely. |
The reason I suppose I bring it up is that users might be confused and think their browser is still listening to them. Which it could. I love this library by the way, I was dealing with just raw pcm before I found this. Good work, everyone past and present who has worked on it. |
Here is my solution to do what I wanted. Taking into consideration that you said the Recorder is intended to be reused.
The idea is that a stream is closed when the recorder is stopped and a new stream is initialised on start. This serves my needs. I hope it's not too messy looking. |
Looks good. I believe you can safely call start and stop and if recorder On 5 May 2015 at 11:55, Kequc notifications@github.com wrote:
|
Heads-up that i have experienced empty buffers when starting recording On 5 May 2015 at 14:52, Chris Rudmin chris.rudmin@gmail.com wrote:
|
Stream now stops when recording is finished. |
Fix issue where number of channels was ignored
The first time an instance of Recorder is created, the user is asked for access to their microphone. In chrome this adds a red icon to the tab. There isn't any way seemingly to end the stream.
In my application I'm creating a new Recorder instance each time I want to record, is this an incorrect way to do things? I've added this.
It would be nice if I could de-initialise the stream as an intended feature of the library.
The text was updated successfully, but these errors were encountered: