-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should provide a License #2
Comments
It's Licensed under MIT license as is the original. It's in the readme. |
I was reviewing the license file, and I did not find anything specifically for your fork Chris. Have you considered adding a MIT (or whatever you prefer) to the license file, something like: Opus-Recorder License (MIT) It is unclear if it is your intent to offer your code (everything that is inherently your copyright) as MIT. The license file essentially is covering your liability for using open source code of others, but users of Opus-Recorder source code don't have a license for your project. I am not an expert in licensing; however, I want to give credit where credit is due and I do not want to infringe on your copyright. |
@TxAg12 I left the license the same as created by Matt Diamond. My code is a fork of his repository. Why would I need to add an additional license? |
For you personally, you met the requirements of the other open source code by including the applicable licenses. However, for the rest of us, there is no license for this specific software. As I understand it, you now own the copyright to _your work, whether or not you actually say "Copyright blah..." So it's basically "unlicensed" unless you provide a license that allows it to be open source, for use by others. I think your intention is to make your repository MIT (correct me if I am incorrect). However, you cannot shift the liability to Matt Diamond by saying it's under his license (which is discussed in the license text). Opus Recorder is yours. Not his (even if much of it is his code). So I think the best way is to make clear your copyright and that you are choosing to also license it as MIT. Here are some links that might be useful: |
Thanks for the information. I will review it and see about updating the license correctly. |
Add worklet process class to encoder
The project provides license details for the source it reuses; however, there doesn't seem to be a license for project itself. You'd expect a copyright notice with the author's name to cover the updates.
The text was updated successfully, but these errors were encountered: