adding configurable target bitrate

[lepinsk]

I've tried to stick close to the coding style used throughout the project.

Rather than fall back on a default target bitrate in recorder.js, if new Recorder is initialized without a bitrate key in the configuration object, the bitrate simply isn't set (which means the encoder goes with its default). I figured this was the best course of action, given that the encoder has different default bitrates depending on the selected encoder application.

[chris-rudmin]

Thanks for the great contribution! Can I suggest a few changes before I merge it?

• Be consistent with camel casing (bitRateLocation instead of bitrateLocation)
• Add the bitRate option on the recordOpus config object instead of the main config object as it will have no effect on Wav recordings
• Document the config option in the readme

[lepinsk]

Sure thing. Good catches.

[lepinsk]

That should do the trick.

[chris-rudmin]

Thanks, after those changes the example.html page stops working. Do you think we really need it in the example?

Edit, the example is working. My bad

[lepinsk]

If you want me to drop it from the example I'm happy to do so. Just lemme know.

[lepinsk]

I've got one more commit where I remove the configurable bitrate from the example.html page – feel free to pull in lepinsk/Recorderjs@8527797 if you want it.

[chris-rudmin]

Nah, lets keep it.

On 28 April 2015 at 20:14, Julian Lepinski notifications@github.com wrote:

I've got one more commit where I remove the configurable bitrate from the
example.html page – feel free to pull in lepinsk/Recorderjs@8527797
lepinsk@8527797
if you want it.

—
Reply to this email directly or view it on GitHub
#11 (comment)
.

[lepinsk]

Sounds good – for the record, I was a bit confused by the dual use of recordOpus as bool / config object (which is probably why I left bitrate out of it when I was first testing things). Perhaps having it in the example will make that part more clear.

[chris-rudmin]

Yes, good point, I agree the dual bool/config is not clear. For future versions, I might drop the wav support. Most people who are interested in this project seem to be interested for the opus encoding.