Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique task_name field to ScheduledTask object #79

Closed
tboulogne opened this issue May 25, 2018 · 4 comments
Closed

Add unique task_name field to ScheduledTask object #79

tboulogne opened this issue May 25, 2018 · 4 comments
Assignees
Projects
Milestone

Comments

@tboulogne
Copy link

Hello Chris,

Back on track after a long silence time.
Look into your update and try it into my project. I face the same problem when i programatically create default task int my project. Each time i reload, the tasks are re-created.

With a unique ID like a a name :
task_name = models.CharField(max_length=200, unique=True) #: task name with uniqueness
We could avoid this.

What do you think to add this ?

Thanks for your feedback.

Regards

@chris104957
Copy link
Owner

I think we can implement this for the next release. The problem we had with this previously was that adding a unique field to an existing model is a bit problematic in terms of exisitng users updating to the new version, because in past releases, users had to create their own migrations. However, carrot now ships with migrations, so we should be able to create a migration that manages this issue.

Leave it with me and I'll try and get something working for next week

@tboulogne
Copy link
Author

thx @chris104957

@chris104957 chris104957 self-assigned this May 30, 2018
@chris104957 chris104957 added this to To do in 1.2 via automation May 30, 2018
@chris104957 chris104957 added this to the 1.2 milestone May 30, 2018
chris104957 pushed a commit that referenced this issue May 30, 2018
`task_name` attribute added to ScheduledTask.
@chris104957
Copy link
Owner

This is now implemented in V1.2

1.2 automation moved this from To do to Done May 30, 2018
@chris104957 chris104957 changed the title duplicata tasks on preset task Add unique task_name field to ScheduledTask object May 30, 2018
@tboulogne
Copy link
Author

thx @chris104957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.2
  
Done
Development

No branches or pull requests

2 participants