Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when click on clink.bat #35

Closed
skywind3000 opened this issue Dec 23, 2020 · 6 comments
Closed

Crash when click on clink.bat #35

skywind3000 opened this issue Dec 23, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@skywind3000
Copy link

skywind3000 commented Dec 23, 2020 •
edited
Loading

System: Windows 10 - 10.0.19042.685
Clink: 1.1.11 bd8deb

Sometimes it works, but later when I start your new clink by clicking clink.bat:

图片

see the attatchment for detail:

clink_crash_report.zip

Hope it could be fixed.
@chrisant996
Copy link
Owner

chrisant996 commented Dec 23, 2020 •
edited
Loading

It may be a regression from the Windows 7 fix. The log shows it's accidentally hooking both ReadConsoleW APIs.

Hopefully fixing it to only hook one ReadConsoleW API will resolve the crash.

But I can't reproduce the problem, so I can't tell for sure. The crash dump shows that calling ReadConsoleW lands in the middle of a completely unrelated OS API. So it seems reasonably likely that this is a regression from the Windows 7 fix, but without being able to reproduce the crash I have no way of investigating deeper or verifying if this change will fix the issue.

When I publish a build with a fix in the morning, please try it and let me know if it's stable again. (And if not, please submit a new crash dump -- that was very helpful, thank you!)

@chrisant996 chrisant996 added the bug Something isn't working label Dec 23, 2020
@chrisant996
Copy link
Owner

Out of curiosity, do you also have Clink 0.4.x installed, and is 0.4.x set up for auto-inject?

@skywind3000
Copy link
Author

There is a clink 0.4.x installed in my computer, but auto-inject has not been enabled.

And at the same time this clink crashed, there wasn't any running instance of clink 0.4.x.

chrisant996 added a commit that referenced this issue Dec 23, 2020
@chrisant996
Try to address mystery crash (#35)
cc20b53 
Issue #35; skywind3000 observed that Clink crashes sometimes when
injecting on Windows 10.  The crash dump shows that ReadConsoleW got
redirected into the middle of a completely unrelated OS API.

I recently fixed Clink on Windows 7 by hooking ReadConsoleW in both
kernelbase.dll and kernel32.dll, and maybe hooking both somehow
contributed to the crash?

Now it only hooks one or the other.  Hopefully this resolves the
intermittent crash.
@chrisant996
Copy link
Owner

v1.1.12 has a speculative fix for this. Please try it when you get a chance.

@skywind3000
Copy link
Author

Using 1.1.13 for one day, no crash encountered.

@chrisant996
Copy link
Owner

Closing this issue, but please reopen if it happens again.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skywind3000 @chrisant996